-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Make function Size::new
const for bevy_ui
widgets
#6602
Closed
kerkmann
wants to merge
2
commits into
bevyengine:main
from
kerkmann:features/6594/make-size-new-consts-for-bevy_ui-widgets
Closed
[Merged by Bors] - Make function Size::new
const for bevy_ui
widgets
#6602
kerkmann
wants to merge
2
commits into
bevyengine:main
from
kerkmann:features/6594/make-size-new-consts-for-bevy_ui-widgets
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
approved these changes
Nov 13, 2022
tim-blackbird
approved these changes
Nov 14, 2022
mockersf
approved these changes
Nov 14, 2022
bors r+ |
Pull request successfully merged into main. Build succeeded:
|
Size::new
const for bevy_ui
widgets
Size::new
const for bevy_ui
widgets
taiyoungjang
pushed a commit
to taiyoungjang/bevy
that referenced
this pull request
Dec 15, 2022
) # Objective Fixes bevyengine#6594 ## Solution - `New` function for `Size` is now a `const` function :) ## Changelog - `New` function for `Size` is now a `const` function ## Migration Guide - Nothing has been changed
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
) # Objective Fixes bevyengine#6594 ## Solution - `New` function for `Size` is now a `const` function :) ## Changelog - `New` function for `Size` is now a `const` function ## Migration Guide - Nothing has been changed
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
) # Objective Fixes bevyengine#6594 ## Solution - `New` function for `Size` is now a `const` function :) ## Changelog - `New` function for `Size` is now a `const` function ## Migration Guide - Nothing has been changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #6594
Solution
New
function forSize
is now aconst
function :)Changelog
New
function forSize
is now aconst
functionMigration Guide