Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Make spawn_dynamic return InstanceId #6663

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Make spawn_dynamic return InstanceId #6663

wants to merge 1 commit into from

Conversation

DasLixou
Copy link
Contributor

Objective

Fixes #6661

Solution

Make SceneSpawner::spawn_dynamic return InstanceId like other functions there.

Changelog

Make SceneSpawner::spawn_dynamic return InstanceId instead of ().

@alice-i-cecile alice-i-cecile added A-Scenes Serialized ECS data stored on the disk M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Nov 17, 2022
@alice-i-cecile alice-i-cecile added this to the 0.10 milestone Nov 17, 2022
@alice-i-cecile alice-i-cecile added the C-Usability A targeted quality-of-life change that makes Bevy easier to use label Nov 17, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 17, 2022
@cart
Copy link
Member

cart commented Nov 18, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 18, 2022
@DasLixou
Make spawn_dynamic return InstanceId (#6663)
4209fca 
# Objective

Fixes #6661 

## Solution

Make `SceneSpawner::spawn_dynamic` return `InstanceId` like other functions there.

---

## Changelog

Make `SceneSpawner::spawn_dynamic` return `InstanceId` instead of `()`.
@bors
Copy link
Contributor

bors bot commented Nov 18, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Make spawn_dynamic return InstanceId [Merged by Bors] - Make spawn_dynamic return InstanceId Nov 18, 2022
@bors bors bot closed this Nov 18, 2022
@DasLixou DasLixou deleted the 6661-spawn-dynamic-return branch November 19, 2022 06:38
taiyoungjang pushed a commit to taiyoungjang/bevy that referenced this pull request Dec 15, 2022
@DasLixou @taiyoungjang
Make spawn_dynamic return InstanceId (bevyengine#6663)
306d47c 
# Objective

Fixes bevyengine#6661 

## Solution

Make `SceneSpawner::spawn_dynamic` return `InstanceId` like other functions there.

---

## Changelog

Make `SceneSpawner::spawn_dynamic` return `InstanceId` instead of `()`.
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@DasLixou @alradish
Make spawn_dynamic return InstanceId (bevyengine#6663)
dfb5bbf 
# Objective

Fixes bevyengine#6661 

## Solution

Make `SceneSpawner::spawn_dynamic` return `InstanceId` like other functions there.

---

## Changelog

Make `SceneSpawner::spawn_dynamic` return `InstanceId` instead of `()`.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@DasLixou @ItsDoot
Make spawn_dynamic return InstanceId (bevyengine#6663)
4b0a936 
# Objective

Fixes bevyengine#6661 

## Solution

Make `SceneSpawner::spawn_dynamic` return `InstanceId` like other functions there.

---

## Changelog

Make `SceneSpawner::spawn_dynamic` return `InstanceId` instead of `()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Scenes Serialized ECS data stored on the disk C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

Make SceneSpawner::spawn_dynamic return the spawned scene's InstanceId
3 participants
@DasLixou @cart @alice-i-cecile