Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Remove warning about missed events due to false positives #6730

Closed

Conversation

alice-i-cecile
Copy link
Member

@alice-i-cecile alice-i-cecile commented Nov 22, 2022

Objective

Solution

Remove the warning entirely.

Changelog

You will no longer be spammed about

Missed 31 bevy_input::mouse::MouseMotion events. Consider
reading from the EventReader more often (generally the best
solution) or calling Events::update() less frequently
(normally this is called once per frame). This problem is most
likely due to run criteria/fixed timesteps or consuming events
conditionally. See the Events documentation for
more information.

when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using ManualEventReader::missed_events

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Nov 22, 2022
@alice-i-cecile
Copy link
Member Author

@rmemr @nicopap @rozgo @forbjok community reviews please :)

Copy link
Contributor

@rparrett rparrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@rozgo
Copy link

rozgo commented Nov 22, 2022

This works.

@hymm
Copy link
Contributor

hymm commented Nov 22, 2022

This still leaves oldest_event_count and missed_events that were added in that PR. I think I'm ok with leaving them as they could potentially help with debugging issues that the warning was trying to prevent.

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Nov 22, 2022
@rmemr
Copy link

rmemr commented Nov 22, 2022

Works for my general usecase. However I do think it is still a useful warning because it also helped me to pinpoint a bug that I would have missed in another case.

Copy link
Contributor

@nicopap nicopap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally only hit this warning as a false positive, but we could make an optional disable-able diagnostic plugin like in #5590. Of course, it doesn't help when it's off and you might not be able to remember to enable it when you start getting a weird issue this diagnostic is supposed to help you figure out. I'm not sure it would be any help in the end, therefore removing the diagnostic without an alternative seems fine.

Maybe some sort of "app stat" plugin could help.

@alice-i-cecile
Copy link
Member Author

Yeah, we can explore other designs for this very real problem later.

bors r+

bors bot pushed a commit that referenced this pull request Nov 23, 2022
# Objective

- Reverts #5730.
- Fixes #6173, fixes #6596.

## Solution

Remove the warning entirely.

## Changelog

You will no longer be spammed about

> Missed 31 `bevy_input::mouse::MouseMotion` events. Consider
reading from the `EventReader` more often (generally the best
solution) or calling Events::update() less frequently
(normally this is called once per frame). This problem is most
likely due to run criteria/fixed timesteps or consuming events
conditionally. See the Events documentation for
more information.

when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
@bors
Copy link
Contributor

bors bot commented Nov 23, 2022

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Nov 23, 2022
# Objective

- Reverts #5730.
- Fixes #6173, fixes #6596.

## Solution

Remove the warning entirely.

## Changelog

You will no longer be spammed about

> Missed 31 `bevy_input::mouse::MouseMotion` events. Consider
reading from the `EventReader` more often (generally the best
solution) or calling Events::update() less frequently
(normally this is called once per frame). This problem is most
likely due to run criteria/fixed timesteps or consuming events
conditionally. See the Events documentation for
more information.

when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
@bors bors bot changed the title Remove warning about missed events due to false positives [Merged by Bors] - Remove warning about missed events due to false positives Nov 23, 2022
@bors bors bot closed this Nov 23, 2022
@cart cart added this to the 0.9.1 milestone Nov 30, 2022
cart pushed a commit that referenced this pull request Nov 30, 2022
# Objective

- Reverts #5730.
- Fixes #6173, fixes #6596.

## Solution

Remove the warning entirely.

## Changelog

You will no longer be spammed about

> Missed 31 `bevy_input::mouse::MouseMotion` events. Consider
reading from the `EventReader` more often (generally the best
solution) or calling Events::update() less frequently
(normally this is called once per frame). This problem is most
likely due to run criteria/fixed timesteps or consuming events
conditionally. See the Events documentation for
more information.

when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
archsolar pushed a commit to archsolar/bevy that referenced this pull request Jan 20, 2023
…#6730)

- Reverts bevyengine#5730.
- Fixes bevyengine#6173, fixes bevyengine#6596.

Remove the warning entirely.

You will no longer be spammed about

> Missed 31 `bevy_input::mouse::MouseMotion` events. Consider
reading from the `EventReader` more often (generally the best
solution) or calling Events::update() less frequently
(normally this is called once per frame). This problem is most
likely due to run criteria/fixed timesteps or consuming events
conditionally. See the Events documentation for
more information.

when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
archsolar pushed a commit to archsolar/bevy that referenced this pull request Jan 20, 2023
…#6730)

# Objective

- Reverts bevyengine#5730.
- Fixes bevyengine#6173, fixes bevyengine#6596.

## Solution

Remove the warning entirely.

## Changelog

You will no longer be spammed about

> Missed 31 `bevy_input::mouse::MouseMotion` events. Consider
reading from the `EventReader` more often (generally the best
solution) or calling Events::update() less frequently
(normally this is called once per frame). This problem is most
likely due to run criteria/fixed timesteps or consuming events
conditionally. See the Events documentation for
more information.

when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…#6730)

# Objective

- Reverts bevyengine#5730.
- Fixes bevyengine#6173, fixes bevyengine#6596.

## Solution

Remove the warning entirely.

## Changelog

You will no longer be spammed about

> Missed 31 `bevy_input::mouse::MouseMotion` events. Consider
reading from the `EventReader` more often (generally the best
solution) or calling Events::update() less frequently
(normally this is called once per frame). This problem is most
likely due to run criteria/fixed timesteps or consuming events
conditionally. See the Events documentation for
more information.

when you miss events. These warnings were often (but not always) a false positive. You can still check this manually by using `ManualEventReader::missed_events`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
8 participants