[Merged by Bors] - Make proc macros hygienic in bevy_reflect_derive #6752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Nov 25, 2022
MrGVSV
approved these changes
Nov 25, 2022
Member
MrGVSV
left a comment
MrGVSV
left a comment
There was a problem hiding this comment.
LGTM! Just one non-blocking comment
crates/bevy_reflect/bevy_reflect_derive/src/container_attributes.rs
Outdated
Show resolved
Hide resolved
Member
|
bors try |
Contributor
tryBuild failed: |
elbertronnie
commented
Nov 26, 2022
MrGVSV
approved these changes
Dec 3, 2022
| @@ -0,0 +1,45 @@ | |||
| use proc_macro2::TokenStream; | |||
Member
There was a problem hiding this comment.
Nit: Not super necessary but it would be nice to either have a module-level doc here stating the purpose of these FQ*** types or doc comments on the individual structs (or both haha).
It's pretty simple/self-explanatory so definitely not required, but I like to make sure the barrier to contributing is low for newcomers :)
Contributor
Author
There was a problem hiding this comment.
I have added the doc too.
MrGVSV
added
the
S-Ready-For-Final-Review
MrGVSV
reviewed
Dec 4, 2022
| use proc_macro2::TokenStream; | ||
| use quote::{quote, ToTokens}; | ||
|
|
||
| // This module contains unit structs that should be used inside `quote!` and `spanned_quote!` using the variable interpolation syntax in place of their equivalent structs and traits present in `std`. |
Member
There was a problem hiding this comment.
Normally module doc comments are made using //! at the very top of the file (above imports). If we include these, could we move them to the top to be consistent with that format?
Contributor
Author
There was a problem hiding this comment.
I have moved them to the top and used //! for the docs.
Initially, I had thought that using //! would make this module visible in the user-facing documentation of Bevy but later realized that won't happen.
alice-i-cecile
removed
the
S-Ready-For-Final-Review
Member
|
Blocking on moving the module comment, then I'll merge. |
alice-i-cecile
approved these changes
Dec 4, 2022
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 5, 2022
# Objective - Fixes #3004 ## Solution - Replaced all the types with their fully quallified names - Replaced all trait methods and inherent methods on dyn traits with their fully qualified names - Made a new file `fq_std.rs` that contains structs corresponding to commonly used Structs and Traits from `std`. These structs are replaced by their respective fully qualified names when used inside `quote!`
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
ickshonpe
pushed a commit
to ickshonpe/bevy
that referenced
this pull request
Dec 6, 2022
# Objective - Fixes bevyengine#3004 ## Solution - Replaced all the types with their fully quallified names - Replaced all trait methods and inherent methods on dyn traits with their fully qualified names - Made a new file `fq_std.rs` that contains structs corresponding to commonly used Structs and Traits from `std`. These structs are replaced by their respective fully qualified names when used inside `quote!`
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective - Fixes bevyengine#3004 ## Solution - Replaced all the types with their fully quallified names - Replaced all trait methods and inherent methods on dyn traits with their fully qualified names - Made a new file `fq_std.rs` that contains structs corresponding to commonly used Structs and Traits from `std`. These structs are replaced by their respective fully qualified names when used inside `quote!`
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective - Fixes bevyengine#3004 ## Solution - Replaced all the types with their fully quallified names - Replaced all trait methods and inherent methods on dyn traits with their fully qualified names - Made a new file `fq_std.rs` that contains structs corresponding to commonly used Structs and Traits from `std`. These structs are replaced by their respective fully qualified names when used inside `quote!`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
fq_std.rsthat contains structs corresponding to commonly used Structs and Traits fromstd. These structs are replaced by their respective fully qualified names when used insidequote!