-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Remove render
feature group
#6912
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shatur
force-pushed
the
remove-render-feature
branch
from
December 11, 2022 00:27
99d7bce
to
7222fa0
Compare
mockersf
approved these changes
Dec 11, 2022
alice-i-cecile
approved these changes
Dec 11, 2022
alice-i-cecile
added
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
labels
Dec 11, 2022
james7132
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Dec 11, 2022
tim-blackbird
approved these changes
Dec 11, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 11, 2022
# Objective The feature doesn't have any use case in libraries or applications and many users use this feature incorrectly. See the issue for details. Closes #5753. ## Solution Remove it. --- ## Changelog ### Removed - `render` feature group. ## Migration Guide Instead of using `render` feature group use dependencies directly. This group consisted of `bevy_core_pipeline`, `bevy_pbr`, `bevy_gltf`, `bevy_render`, `bevy_sprite`, `bevy_text` and `bevy_ui`. You probably want to check if you need all of them.
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Remove
[Merged by Bors] - Remove Dec 11, 2022
render
feature grouprender
feature group
alradish
pushed a commit
to alradish/bevy
that referenced
this pull request
Jan 22, 2023
# Objective The feature doesn't have any use case in libraries or applications and many users use this feature incorrectly. See the issue for details. Closes bevyengine#5753. ## Solution Remove it. --- ## Changelog ### Removed - `render` feature group. ## Migration Guide Instead of using `render` feature group use dependencies directly. This group consisted of `bevy_core_pipeline`, `bevy_pbr`, `bevy_gltf`, `bevy_render`, `bevy_sprite`, `bevy_text` and `bevy_ui`. You probably want to check if you need all of them.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
# Objective The feature doesn't have any use case in libraries or applications and many users use this feature incorrectly. See the issue for details. Closes bevyengine#5753. ## Solution Remove it. --- ## Changelog ### Removed - `render` feature group. ## Migration Guide Instead of using `render` feature group use dependencies directly. This group consisted of `bevy_core_pipeline`, `bevy_pbr`, `bevy_gltf`, `bevy_render`, `bevy_sprite`, `bevy_text` and `bevy_ui`. You probably want to check if you need all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Meta
About the project itself
A-Rendering
Drawing game state to the screen
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The feature doesn't have any use case in libraries or applications and many users use this feature incorrectly. See the issue for details.
Closes #5753.
Solution
Remove it.
Changelog
Removed
render
feature group.Migration Guide
Instead of using
render
feature group use dependencies directly. This group consisted ofbevy_core_pipeline
,bevy_pbr
,bevy_gltf
,bevy_render
,bevy_sprite
,bevy_text
andbevy_ui
. You probably want to check if you need all of them.