Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Shadow render phase - pass the correct view entity #7048

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Shadow render phase - pass the correct view entity #7048

wants to merge 1 commit into from

Conversation

mockersf
Copy link
Member

Objective

Solution

  • Pass the correct view entity

@mockersf mockersf added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Dec 28, 2022
superdump
superdump approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Dec 28, 2022
@mockersf
Shadow render phase - pass the correct view entity (#7048)
61e027e 
# Objective

- Fixes #7047 

## Solution

- Pass the correct view entity
@bors
Copy link
Contributor

bors bot commented Dec 28, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Shadow render phase - pass the correct view entity [Merged by Bors] - Shadow render phase - pass the correct view entity Dec 28, 2022
@bors bors bot closed this Dec 28, 2022
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@mockersf @alradish
Shadow render phase - pass the correct view entity (bevyengine#7048)
39086a8 
# Objective

- Fixes bevyengine#7047 

## Solution

- Pass the correct view entity
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@mockersf @ItsDoot
Shadow render phase - pass the correct view entity (bevyengine#7048)
3cca041 
# Objective

- Fixes bevyengine#7047 

## Solution

- Pass the correct view entity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@superdump superdump superdump approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

shadows are messed up
3 participants
@mockersf @superdump @james7132