Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled clippy type complexity lints globally for all crates. #7050

Closed
wants to merge 2 commits into from
Closed

Disabled clippy type complexity lints globally for all crates. #7050

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ec5666
Disabled type complexity lints globally for all crates.
iiYese Dec 28, 2022
64dd0ed
Reverted lib.rs changes and applied suggested .cargo changes
iiYese Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[target.'cfg(all())']
rustflags = ["-Aclippy::type_complexity"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still forks the configuration we have in the CI script. We should have one source of truth for global lint configuration. Either it is all here, or it is all in the CI script.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're moving config here, we should also verify that the CI script is still picking up these flags.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The big downside to this approach is that config.toml is considered "local user configuration".
Notably, we encourage people to include platform specific linker optimizations here:

[target.x86_64-unknown-linux-gnu]
linker = "/usr/bin/clang"
rustflags = ["-C", "link-arg=--ld-path=/usr/bin/mold"]

These linker settings will be per-system config and shouldn't be enabled by default. Currently we .gitignore this file. Checking this in is "controversial" and will almost certainly negatively affect these workflows.