Don't ignore additional entries in UntypedReflectDeserializerVisitor
#7112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Currently when
UntypedReflectDeserializerVisitor
deserializes aBox<dyn Reflect>
it only considers the first entry of the map, silently ignoring any additional entries. For example the following RON data:is successfully deserialized as a
f32
, completly ignoring the"u32": 1
part.Solution
UntypedReflectDeserializerVisitor
was changed to check if any other key could be deserialized, and in that case returns an error.Changelog
UntypedReflectDeserializer
now errors on malformed inputs instead of silently disgarding additional data.Migration Guide
If you were deserializing
Box<dyn Reflect>
values with multiple entries (i.e. entries other than"type": { /* fields */ }
) you should remove them or deserialization will fail.