Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example for Camera::viewport_to_world #7179

Merged
merged 14 commits into from
Sep 11, 2023
Merged

Add example for Camera::viewport_to_world #7179

merged 14 commits into from
Sep 11, 2023

Conversation

tim-blackbird
Copy link
Contributor

@tim-blackbird tim-blackbird commented Jan 13, 2023 •
edited
Loading

Fixes #7177

mockersf
mockersf requested changes Jan 13, 2023
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add an example description at the tope of the example in comments?

@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples A-Rendering Drawing game state to the screen labels Jan 13, 2023
@tim-blackbird tim-blackbird force-pushed the cursor-to-world-example branch from b737622 to ed5ad30 Compare March 13, 2023 15:48
@tim-blackbird tim-blackbird requested a review from rparrett March 25, 2023 13:59
@tim-blackbird tim-blackbird force-pushed the cursor-to-world-example branch from 993ac28 to 960c8cd Compare April 6, 2023 11:27
rparrett
rparrett reviewed Apr 6, 2023
View reviewed changes
examples/README.md Outdated Show resolved Hide resolved
@rparrett rparrett mentioned this pull request Apr 28, 2023
Open
@tim-blackbird
Copy link
Contributor Author

I've added an example for 2D as well.

@tim-blackbird @rparrett
Simplify plane mesh creation
e2b4bd4 
Co-authored-by: Rob Parrett <robparrett@gmail.com>
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Sep 9, 2023
alice-i-cecile
alice-i-cecile approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very practical but still simple. I really like it.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 11, 2023
Merged via the queue into bevyengine:main with commit f3ab38a Sep 11, 2023
@tim-blackbird tim-blackbird deleted the cursor-to-world-example branch September 12, 2023 10:05
rdrpenguin04 pushed a commit to rdrpenguin04/bevy that referenced this pull request Jan 9, 2024
@tim-blackbird @rparrett
Add example for Camera::viewport_to_world (bevyengine#7179)
ab3e177 
Fixes bevyengine#7177

---------

Co-authored-by: Rob Parrett <robparrett@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@rparrett rparrett rparrett approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Demonstrate how to use Camera::viewport_to_word
4 participants
@tim-blackbird @rparrett @alice-i-cecile @mockersf