Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Implement ReadOnlySystemParam for Extract<> #7182

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Implement ReadOnlySystemParam for Extract<> #7182

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8615306
impl `ReadOnlySystemParam` for `Extract<>`
joseph-gio Jan 13, 2023
e44cca5
typo
joseph-gio Jan 13, 2023
41524ac
clarify which world access a comment refers to
joseph-gio Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions crates/bevy_render/src/extract_param.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,10 @@ pub struct ExtractState<P: SystemParam + 'static> {
main_world_state: <Res<'static, MainWorld> as SystemParam>::State,
}

// SAFETY: only accesses MainWorld resource with read only system params using Res,
// which is initialized in init()
// SAFETY: The only `World` access (`Res<MainWorld>`) is read-only.
unsafe impl<P> ReadOnlySystemParam for Extract<'_, '_, P> where P: ReadOnlySystemParam {}

// SAFETY: The only `World` access is properly registered by `Res<MainWorld>::init_state`.
unsafe impl<P> SystemParam for Extract<'_, '_, P>
where
P: ReadOnlySystemParam,
Expand Down