[Merged by Bors] - schedule_v3: fix default set for systems not being applied #7350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-blackbird
approved these changes
Jan 24, 2023
alice-i-cecile
added
C-Bug
alice-i-cecile
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
I'm going to manually cherrypick these changes into #7267 too.
bors r+
bors bot
pushed a commit
that referenced
this pull request
Jan 24, 2023
# Objective `add_system(system)` without any `.in_set` configuration should land in `CoreSet::Update`. We check that the sets are empty, but for systems there is always the `SystemTypeset`. ## Solution - instead of `is_empty()`, check that the only set it the `SystemTypeSet`
bors
bot
changed the title
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…e#7350) # Objective `add_system(system)` without any `.in_set` configuration should land in `CoreSet::Update`. We check that the sets are empty, but for systems there is always the `SystemTypeset`. ## Solution - instead of `is_empty()`, check that the only set it the `SystemTypeSet`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
add_system(system)without any.in_setconfiguration should land inCoreSet::Update.We check that the sets are empty, but for systems there is always the
SystemTypeset.Solution
is_empty(), check that the only set it theSystemTypeSet