Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix a few uninlined_format_args lints #7368

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix a few uninlined_format_args lints #7368

wants to merge 2 commits into from

Conversation

rparrett
Copy link
Contributor

Objective

Prevent things from breaking tomorrow when rust 1.67 is released.

Solution

Fix a few uninlined_format_args lints in recently introduced code.

@james7132 james7132 added this to the 0.10 milestone Jan 26, 2023
@james7132 james7132 added C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jan 26, 2023
tim-blackbird
tim-blackbird approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@tim-blackbird tim-blackbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is currently blocked on this :p

@james7132
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 26, 2023
@rparrett
Fix a few uninlined_format_args lints (#7368)
c4dd80c 
# Objective

Prevent things from breaking tomorrow when rust 1.67 is released.

## Solution

Fix a few `uninlined_format_args` lints in recently introduced code.
@bors
Copy link
Contributor

bors bot commented Jan 26, 2023

Build failed:

@james7132
Copy link
Member

There seems to be one missed one in examples/shader/texture_binding_array.rs.

@rparrett
Copy link
Contributor Author

rparrett commented Jan 26, 2023 •
edited
Loading

Got it. That example was added after this PR.

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jan 26, 2023
@rparrett
Fix a few uninlined_format_args lints (#7368)
461497f 
# Objective

Prevent things from breaking tomorrow when rust 1.67 is released.

## Solution

Fix a few `uninlined_format_args` lints in recently introduced code.
@bors
Copy link
Contributor

bors bot commented Jan 26, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix a few uninlined_format_args lints [Merged by Bors] - Fix a few uninlined_format_args lints Jan 26, 2023
@bors bors bot closed this Jan 26, 2023
@Elabajaba Elabajaba mentioned this pull request Jan 26, 2023
Closed
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@rparrett @ItsDoot
Fix a few uninlined_format_args lints (bevyengine#7368)
a1b41a1 
# Objective

Prevent things from breaking tomorrow when rust 1.67 is released.

## Solution

Fix a few `uninlined_format_args` lints in recently introduced code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.
4 participants
@rparrett @james7132 @alice-i-cecile @tim-blackbird