Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Update toml_edit to 0.18 #7370

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Update toml_edit to 0.18 #7370

wants to merge 1 commit into from

Conversation

tim-blackbird
Copy link
Contributor

Removes a duplicate dependency from the tree

@TimJentzsch
Copy link
Contributor

TimJentzsch commented Jan 26, 2023 •
edited
Loading

If a duplicate dependency got removed, deny.toml should probably be updated to disallow that duplicate again

@mockersf
Copy link
Member

it's not in the deny.toml file

@mockersf mockersf added C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jan 26, 2023
james7132
james7132 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot pushed a commit that referenced this pull request Jan 26, 2023
@tim-blackbird
Update toml_edit to 0.18 (#7370)
54a95c9 
Removes a duplicate dependency from the tree

Co-authored-by: devil-ira <justthecooldude@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 26, 2023

Build failed:

@james7132
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Jan 26, 2023
@tim-blackbird
Update toml_edit to 0.18 (#7370)
aab518a 
Removes a duplicate dependency from the tree

Co-authored-by: devil-ira <justthecooldude@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 26, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Update toml_edit to 0.18 [Merged by Bors] - Update toml_edit to 0.18 Jan 26, 2023
@bors bors bot closed this Jan 26, 2023
@Elabajaba Elabajaba mentioned this pull request Jan 26, 2023
Closed
@tim-blackbird tim-blackbird deleted the toml-edit-0.18 branch January 27, 2023 16:23
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@tim-blackbird @ItsDoot
Update toml_edit to 0.18 (bevyengine#7370)
ca710ab 
Removes a duplicate dependency from the tree

Co-authored-by: devil-ira <justthecooldude@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimJentzsch TimJentzsch TimJentzsch approved these changes

@mockersf mockersf mockersf approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tim-blackbird @TimJentzsch @mockersf @james7132