Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix feature gating in texture_binding_array example #7425

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Fix feature gating in texture_binding_array example #7425

wants to merge 1 commit into from

Conversation

rparrett
Copy link
Contributor

@rparrett rparrett commented Jan 30, 2023 •
edited
Loading

Objective

Fixes #7374

Solution

Move the feature gate into main, before MaterialPlugin::<BindlessMaterial> is added, as described in #7374 (comment)

@rparrett rparrett added C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples A-Rendering Drawing game state to the screen labels Jan 30, 2023
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 6, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 6, 2023
@rparrett
Fix feature gating in texture_binding_array example (#7425)
b1bb2e3 
# Objective

Fixes #7374

## Solution

Move the feature gate into `main`, before `MaterialPlugin::<BindlessMaterial>` is added, as described in #7374 (comment)
@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

Build failed:

@alice-i-cecile
Copy link
Member

bors retry

bors bot pushed a commit that referenced this pull request Feb 6, 2023
@rparrett
Fix feature gating in texture_binding_array example (#7425)
5b930c8 
# Objective

Fixes #7374

## Solution

Move the feature gate into `main`, before `MaterialPlugin::<BindlessMaterial>` is added, as described in #7374 (comment)
@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix feature gating in texture_binding_array example [Merged by Bors] - Fix feature gating in texture_binding_array example Feb 6, 2023
@bors bors bot closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@robtfm robtfm robtfm approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

texture_binding_array example's WgpuFeature gating is not working
4 participants
@rparrett @alice-i-cecile @james7132 @robtfm