Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Rename the background_color of 'ExtractedUiNode to color` #7452

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Rename the background_color of 'ExtractedUiNode to color` #7452

wants to merge 1 commit into from

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Jan 31, 2023 •
edited
Loading

Problem

The field is called background_color but it is also used to hold the colors of text glyphs and images.
It's mildly confusing and longer to type than just color.

Solution

Rename background_color to color.

Changelog

  • Renamed the background_color field of ExtractedUiNode to color.

Migration Guide

  • The background_color field of ExtractedUiNode is now named color.

@ickshonpe
changes:
43445fa 
* renamed the field `background_color` of `ExtractedUiNodes` to `color`
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Jan 31, 2023
james7132
james7132 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 1, 2023
bors bot pushed a commit that referenced this pull request Feb 1, 2023
@ickshonpe
Rename the background_color of 'ExtractedUiNode to color` (#7452)
f3b8ff6 
# Problem
The field is called `background_color` but it is also used to hold the colors of text glyphs and images.
It's mildly confusing and longer to type than just `color`.

## Solution
Rename `background_color` to `color`.

## Changelog
* Renamed the `background_color` field of `ExtractedUiNode` to `color`.

## Migration Guide
* The `background_color` field of `ExtractedUiNode` is now named `color`.
@bors
Copy link
Contributor

bors bot commented Feb 1, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Rename the background_color of 'ExtractedUiNode to color` [Merged by Bors] - Rename the background_color of 'ExtractedUiNode to color` Feb 1, 2023
@bors bors bot closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ickshonpe @james7132 @alice-i-cecile