[Merged by Bors] - fix typo in bevy_reflect::impls::std GetTypeRegistration for vec like… #7520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… object, it only implements for Vec<T>, but not
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
MrGVSV
added
C-Bug
james7132
approved these changes
Feb 6, 2023
james7132
added
the
S-Ready-For-Final-Review
jakobhellermann
approved these changes
Feb 6, 2023
mockersf
approved these changes
Feb 6, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
#7520) Implementing GetTypeRegistration in macro impl_reflect_for_veclike! had typos! It only implement GetTypeRegistration for Vec<T>, but not for VecDeque<T>. This will cause serialization and deserialization failure.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing GetTypeRegistration in macro impl_reflect_for_veclike! had typos!
It only implement GetTypeRegistration for Vec, but not for VecDeque.
This will cause serialization and deserialization failure.