Add Resource information to AmbientLight Docs #7540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses bevyengine#7465. The documentation now tells the reader that AmbientLight is a Resource that has a default color of white and a default brightness of 0.05
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
|
Example |
superdump
added
C-Docs
SpecificProtagonist
suggested changes
Feb 7, 2023
|
Thanks. Looks like bevy_pbr isn't correct either. I'm not sure, might need to be crate::PbrPlugin, but I can't check right now. |
mockersf
approved these changes
May 13, 2023
|
Looks like similar work was merged in #10712 and at least one other PR improving I'm going to close this up, but please feel free to reopen and fix it up or open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obejctives
Fixes #7465.
Solution
The documentation now tells the reader that AmbientLight is a Resource that has a default color of white and a default brightness of 0.05