Remove impl ScheduleLabel for Box<dyn ScheduleLabel>

crates/bevy_app/src/app.rs

@@ -987,7 +987,7 @@ impl App {
         let mut schedules = self.world.resource_mut::<Schedules>();
 
         if schedules.get(&label).is_none() {
-            schedules.insert(label.dyn_clone(), Schedule::new());
+            schedules.insert_boxed(label.dyn_clone(), Schedule::new());
         }
 
         let schedule = schedules.get_mut(&label).unwrap();

crates/bevy_ecs/src/schedule/schedule.rs

@@ -43,6 +43,21 @@ impl Schedules {
     /// and the old schedule is returned. Otherwise, `None` is returned.
     pub fn insert(&mut self, label: impl ScheduleLabel, schedule: Schedule) -> Option<Schedule> {
         let label = label.dyn_clone();
+        self.insert_boxed(label, schedule)
+    }
+
+    /// Inserts a labeled schedule into the map.
+    ///
+    /// Unlike `insert`, this method takes a [`BoxedScheduleLabel`]. This is useful when you
+    /// do not have a concrete schedule label and only a boxed version of it.
+    ///
+    /// If the map already had an entry for `label`, `schedule` is inserted,
+    /// and the old schedule is returned. Otherwise, `None` is returned.
+    pub fn insert_boxed(
+        &mut self,
+        label: BoxedScheduleLabel,
+        schedule: Schedule,
+    ) -> Option<Schedule> {
         if self.inner.contains_key(&label) {
             warn!("schedule with label {:?} already exists", label);
         }

crates/bevy_ecs/src/world/mod.rs

@@ -1726,7 +1726,8 @@ impl World {
 
     /// Runs the [`Schedule`] associated with the `label` a single time.
     ///
-    /// Unlike the `run_schedule` method, this method takes the label by reference, which can save a clone.
+    /// Unlike the `run_schedule` method, this method takes the label by reference. This is useful
+    /// when you have the schedule label behind a pointer, such as a `Box`.
     ///
     /// The [`Schedule`] is fetched from the [`Schedules`] resource of the world by its label,
     /// and system state is cached.
@@ -1747,7 +1748,7 @@ impl World {
         let _span = bevy_utils::tracing::info_span!("schedule", name = ?extracted_label).entered();
         schedule.run(self);
         self.resource_mut::<Schedules>()
-            .insert(extracted_label, schedule);
+            .insert_boxed(extracted_label, schedule);
     }
 }
 

crates/bevy_utils/src/label.rs

@@ -98,14 +98,6 @@ macro_rules! define_boxed_label {
                 self.dyn_clone()
             }
         }
-
-        impl $label_trait_name for Box<dyn $label_trait_name> {
-            fn dyn_clone(&self) -> Box<dyn $label_trait_name> {
-                // Be explicit that we want to use the inner value
-                // to avoid infinite recursion.
-                (**self).dyn_clone()
-            }
-        }
     };
 }