Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add AND/OR combinators for run conditions #7605

Closed
wants to merge 40 commits into from
Closed

[Merged by Bors] - Add AND/OR combinators for run conditions #7605

wants to merge 40 commits into from

Commits on Feb 10, 2023

  1. add a struct for making generic system combinators

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    50bd3b0 View commit details
    Browse the repository at this point in the history

  2. implement PipeSystem using CombinatorSystem

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    7d3c53e View commit details
    Browse the repository at this point in the history

  3. and and_then/or_else combinators

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    f2d5b08 View commit details
    Browse the repository at this point in the history

  4. tweak a safety comment 

    Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
    @JoJoJet @alice-i-cecile
    JoJoJet and alice-i-cecile authored Feb 10, 2023
    Configuration menu
    Copy the full SHA
    6fa420a View commit details
    Browse the repository at this point in the history

  5. add docs to and_then and or_else

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    8e2579d View commit details
    Browse the repository at this point in the history

  6. add docs to CombinatorSystem

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    d91d906 View commit details
    Browse the repository at this point in the history

  7. add a doctest to Combine

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    78524ba View commit details
    Browse the repository at this point in the history

  8. update doctest

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    d353e06 View commit details
    Browse the repository at this point in the history

  9. fix some mistakes in the doctest

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    435c657 View commit details
    Browse the repository at this point in the history

  10. typo

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    40ab70a View commit details
    Browse the repository at this point in the history

  11. use IntoSystem properly

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    2b76184 View commit details
    Browse the repository at this point in the history

  12. resource -> state

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    5a437c6 View commit details
    Browse the repository at this point in the history

  13. reorder generics

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    1fd4d1e View commit details
    Browse the repository at this point in the history

  14. derive eq

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    d76bc89 View commit details
    Browse the repository at this point in the history

  15. update renamed variables

    @JoJoJet
    JoJoJet committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    9d212e8 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2023

  1. use fully qualiified Cow

    @JoJoJet
    JoJoJet committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    892b1da View commit details
    Browse the repository at this point in the history

  2. fix a where clause

    @JoJoJet
    JoJoJet committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    c25c564 View commit details
    Browse the repository at this point in the history

  3. simplify Combine::combine

    @JoJoJet
    JoJoJet committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    b775326 View commit details
    Browse the repository at this point in the history

  4. remove Combine::combine_exclusive

    @JoJoJet
    JoJoJet committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    f6e3fbc View commit details
    Browse the repository at this point in the history

  5. add safety comments to run_unsafe

    @JoJoJet
    JoJoJet committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    6cd5eef View commit details
    Browse the repository at this point in the history

  6. remove some unnecessary fully qualified types

    @JoJoJet
    JoJoJet committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    685c712 View commit details
    Browse the repository at this point in the history

  7. use UnsafeCell to retain lifetimes

    @JoJoJet
    JoJoJet committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    affe2d9 View commit details
    Browse the repository at this point in the history

  8. improve safety comments for CombinatorSystem

    @JoJoJet
    JoJoJet committed Feb 11, 2023
    Configuration menu
    Copy the full SHA
    c077ed1 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2023

  1. add a note pointing to the docs on Combine

    @JoJoJet
    JoJoJet committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    6f2a8d0 View commit details
    Browse the repository at this point in the history

  2. document members of Combine trait

    @JoJoJet
    JoJoJet committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    3dcfc0b View commit details
    Browse the repository at this point in the history

  3. use a correct parameter name

    @JoJoJet
    JoJoJet committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    7a4c5a5 View commit details
    Browse the repository at this point in the history

  4. add a doctest to and_then

    @JoJoJet
    JoJoJet committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    a09eb71 View commit details
    Browse the repository at this point in the history

  5. add a doctest to or_else

    @JoJoJet
    JoJoJet committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    0a26bbd View commit details
    Browse the repository at this point in the history

  6. add a missing derive

    @JoJoJet
    JoJoJet committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    514e4ca View commit details
    Browse the repository at this point in the history

  7. state -> resource

    @JoJoJet
    JoJoJet committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    5e948c7 View commit details
    Browse the repository at this point in the history

  8. declare a forgotten function

    @JoJoJet
    JoJoJet committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    ef26671 View commit details
    Browse the repository at this point in the history

  9. add docs to AndThen/OrElse typedefs

    @JoJoJet
    JoJoJet committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    b1ddab8 View commit details
    Browse the repository at this point in the history

  10. add Condition<> to the prelude

    @JoJoJet
    JoJoJet committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    96301c8 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'upstream/main' into combine-system

    @JoJoJet
    JoJoJet committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    174e75f View commit details
    Browse the repository at this point in the history

  12. Update crates/bevy_ecs/src/system/combinator.rs 

    Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
    @JoJoJet @alice-i-cecile
    JoJoJet and alice-i-cecile authored Feb 12, 2023
    Configuration menu
    Copy the full SHA
    caafd21 View commit details
    Browse the repository at this point in the history

  13. remove an extra word

    @JoJoJet
    JoJoJet committed Feb 12, 2023
    Configuration menu
    Copy the full SHA
    1302b62 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. combine default system sets

    @JoJoJet
    JoJoJet committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    9c1ed08 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Merge remote-tracking branch 'upstream/main' into combine-system

    @JoJoJet
    JoJoJet committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    03f7e40 View commit details
    Browse the repository at this point in the history

  2. add a note about default short circuiting behavior

    @JoJoJet
    JoJoJet committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    5a14d65 View commit details
    Browse the repository at this point in the history

  3. add and_then to the example for run conditions

    @JoJoJet
    JoJoJet committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    35bfba1 View commit details
    Browse the repository at this point in the history