Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Transparent window on macos #7617

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Transparent window on macos #7617

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Feb 11, 2023 •
edited
Loading

Objective

Solution

  • Set the composite_alpha_mode of the window to the correct value
  • Update docs

@mockersf mockersf mentioned this pull request Feb 11, 2023
Open
@mockersf mockersf added C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples A-Windowing Platform-agnostic interface layer to run your app in O-MacOS Specific to the MacOS (Apple) desktop operating system labels Feb 11, 2023
@rparrett
Copy link
Contributor

relevant bevy issue: #6330

james7132
james7132 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on confirmation of this working from others on Discord. Deferring final approval to another maintainer that can verify this works.

@mockersf mockersf force-pushed the transparent-window-macos branch from 892a362 to 4f4801a Compare February 27, 2023 21:38
@rparrett
Copy link
Contributor

rparrett commented Mar 4, 2023

This works for me. (M1, MacOS 13.1)

Am I right that this is baking the current workaround into the example, and that there's still some wgpu issue affecting this?

superdump
superdump approved these changes Mar 4, 2023
View reviewed changes
Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Works.

bors r+

bors bot pushed a commit that referenced this pull request Mar 4, 2023
@mockersf
Transparent window on macos (#7617)
57bf771 
# Objective

- Example `transparent_window` doesn't display a transparent window on macOS
- Fixes #6330

## Solution

- Set the `composite_alpha_mode` of the window to the correct value
- Update docs
@bors
Copy link
Contributor

bors bot commented Mar 4, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Transparent window on macos [Merged by Bors] - Transparent window on macos Mar 4, 2023
@bors bors bot closed this Mar 4, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@mockersf @Shfty
Transparent window on macos (bevyengine#7617)
50544d6 
# Objective

- Example `transparent_window` doesn't display a transparent window on macOS
- Fixes bevyengine#6330

## Solution

- Set the `composite_alpha_mode` of the window to the correct value
- Update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james7132 james7132 james7132 approved these changes

@superdump superdump superdump approved these changes

Assignees
No one assigned
Labels
A-Windowing Platform-agnostic interface layer to run your app in C-Docs An addition or correction to our documentation C-Examples An addition or correction to our examples O-MacOS Specific to the MacOS (Apple) desktop operating system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transparent windows on macOS are opaque
4 participants
@mockersf @rparrett @superdump @james7132