-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - introduce EntityLocation::INVALID const and adjust Entities::get comment #7623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Feb 11, 2023
alice-i-cecile
added
the
C-Code-Quality
A section of code that is hard to understand or change
label
Feb 11, 2023
JoJoJet
approved these changes
Feb 11, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
label
Feb 11, 2023
james7132
approved these changes
Feb 15, 2023
@james7132 ping |
james7132
reviewed
Feb 18, 2023
james7132
approved these changes
Feb 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
bors bot
pushed a commit
that referenced
this pull request
Feb 18, 2023
…ent (#7623) also remove one un-needed mut.
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
introduce EntityLocation::INVALID const and adjust Entities::get comment
[Merged by Bors] - introduce EntityLocation::INVALID const and adjust Entities::get comment
Feb 18, 2023
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 20, 2023
…ent (bevyengine#7623) also remove one un-needed mut.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ECS
Entities, components, systems, and events
C-Code-Quality
A section of code that is hard to understand or change
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also remove one un-needed mut.