Fix the Size helper functions using the wrong default value and improve the UI examples #7625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Size::width
sets theheight
field toVal::DEFAULT
which isVal::Undefined
, but the default forSize
isVal::Auto
.Size::height
has the same problem, but with thewidth
field.The UI examples specify numeric values in many places where they could either be elided or replaced by composition of the flex enum properties.
related: #6498, #7468
Solution
Change
Size::width
so it setsheight
toVal::AUTO
and changeSize::height
so it setswidth
toVal::AUTO
.Changelog
Size::width
so it sets theheight
toVal::AUTO
Size::height
so it sets thewidth
toVal::AUTO
.geometry.rs
forSize
andUiRect
to ensure correct behaviour.