Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add Beziers to bevy_math #7653

Closed
wants to merge 18 commits into from
Closed

[Merged by Bors] - Add Beziers to bevy_math #7653

wants to merge 18 commits into from

Commits on Feb 13, 2023

  1. Initial cubic bezier implementation

    @aevyrie
    aevyrie committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    9f1d944 View commit details
    Browse the repository at this point in the history

  2. Add trait methods to types

    @aevyrie
    aevyrie committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    358b47b View commit details
    Browse the repository at this point in the history

  3. Rename into_points to to_points 

    Methods that borrow `self` should use `to` instead of `into`.
    @aevyrie
    aevyrie committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    cbd556a View commit details
    Browse the repository at this point in the history

  4. Refactor to use generic function instead of trait.

    @aevyrie
    aevyrie committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    91a6f0c View commit details
    Browse the repository at this point in the history

  5. Ensure implementation functions are inlined

    @aevyrie
    aevyrie committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    7b884b6 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. generic impl with benchmarks

    @aevyrie
    aevyrie committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    25beaea View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary returns

    @aevyrie
    aevyrie committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    d1df0d8 View commit details
    Browse the repository at this point in the history

  3. Update crates/bevy_math/src/bezier.rs 

    Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
    @aevyrie @alice-i-cecile
    aevyrie and alice-i-cecile authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    af90a00 View commit details
    Browse the repository at this point in the history

  4. REview feedback

    @aevyrie
    aevyrie committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    09354af View commit details
    Browse the repository at this point in the history

  5. Improve easing API

    @aevyrie
    aevyrie committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6786399 View commit details
    Browse the repository at this point in the history

  6. Improve docs

    @aevyrie
    aevyrie committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    c8c4eef View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Doc corrections

    @aevyrie
    aevyrie committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    d0253ca View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Mark inline code art as text

    @aevyrie
    aevyrie committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    de415cc View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Update crates/bevy_math/src/bezier.rs 

    Co-authored-by: JoJoJet <21144246+JoJoJet@users.noreply.github.com>
    @aevyrie @JoJoJet
    aevyrie and JoJoJet authored Feb 18, 2023
    Configuration menu
    Copy the full SHA
    b5077e7 View commit details
    Browse the repository at this point in the history

  2. fn cannot be constant

    @aevyrie
    aevyrie committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    7c2ea64 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Apply suggestions from code review 

    Co-authored-by: James Liu <contact@jamessliu.com>
    @aevyrie @james7132
    aevyrie and james7132 authored Feb 20, 2023
    Configuration menu
    Copy the full SHA
    41e6624 View commit details
    Browse the repository at this point in the history

  2. Add tests, update docs, improve constructor

    @aevyrie
    aevyrie committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    2aa5a94 View commit details
    Browse the repository at this point in the history

  3. ci fixes

    @aevyrie
    aevyrie committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    109a17f View commit details
    Browse the repository at this point in the history