[Merged by Bors] - Change standard material defaults and update docs #7664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JMS55
suggested changes
Feb 13, 2023
JMS55
added
C-Docs
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
mockersf
reviewed
Feb 13, 2023
JMS55
approved these changes
Feb 13, 2023
IceSentry
approved these changes
Feb 13, 2023
bors bot
pushed a commit
that referenced
this pull request
Feb 14, 2023
# Objective Standard material defaults are currently strange, and the docs are wrong re: metallic. ## Solution Change the defaults to be similar to [Godot](godotengine/godot#62756). --- ## Changelog #### Changed - `StandardMaterial` now defaults to a dielectric material (0.0 `metallic`) with 0.5 `perceptual_roughness`. ## Migration Guide `StandardMaterial`'s default have now changed to be a fully dielectric material with medium roughness. If you want to use the old defaults, you can set `perceptual_roughness = 0.089` and `metallic = 0.01` (though metallic should generally only be set to 0.0 or 1.0).
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 15, 2023
# Objective Standard material defaults are currently strange, and the docs are wrong re: metallic. ## Solution Change the defaults to be similar to [Godot](godotengine/godot#62756). --- ## Changelog #### Changed - `StandardMaterial` now defaults to a dielectric material (0.0 `metallic`) with 0.5 `perceptual_roughness`. ## Migration Guide `StandardMaterial`'s default have now changed to be a fully dielectric material with medium roughness. If you want to use the old defaults, you can set `perceptual_roughness = 0.089` and `metallic = 0.01` (though metallic should generally only be set to 0.0 or 1.0).
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 15, 2023
# Objective Standard material defaults are currently strange, and the docs are wrong re: metallic. ## Solution Change the defaults to be similar to [Godot](godotengine/godot#62756). --- ## Changelog #### Changed - `StandardMaterial` now defaults to a dielectric material (0.0 `metallic`) with 0.5 `perceptual_roughness`. ## Migration Guide `StandardMaterial`'s default have now changed to be a fully dielectric material with medium roughness. If you want to use the old defaults, you can set `perceptual_roughness = 0.089` and `metallic = 0.01` (though metallic should generally only be set to 0.0 or 1.0).
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 15, 2023
# Objective Standard material defaults are currently strange, and the docs are wrong re: metallic. ## Solution Change the defaults to be similar to [Godot](godotengine/godot#62756). --- ## Changelog #### Changed - `StandardMaterial` now defaults to a dielectric material (0.0 `metallic`) with 0.5 `perceptual_roughness`. ## Migration Guide `StandardMaterial`'s default have now changed to be a fully dielectric material with medium roughness. If you want to use the old defaults, you can set `perceptual_roughness = 0.089` and `metallic = 0.01` (though metallic should generally only be set to 0.0 or 1.0).
mockersf
pushed a commit
that referenced
this pull request
Apr 14, 2023
# Objective The default StandardMaterial values of `pbr_material.rs` and `pbr_types.wgsl` are out of sync. I think they are out of sync since #7664. ## Solution Adapt the values: `metallic = 0.0`, `perceptual_roughness = 0.5`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Standard material defaults are currently strange, and the docs are wrong re: metallic.
Solution
Change the defaults to be similar to Godot.
Changelog
Changed
StandardMaterialnow defaults to a dielectric material (0.0metallic) with 0.5perceptual_roughness.Migration Guide
StandardMaterial's default have now changed to be a fully dielectric material with medium roughness. If you want to use the old defaults, you can setperceptual_roughness = 0.089andmetallic = 0.01(though metallic should generally only be set to 0.0 or 1.0).