Change default wgpu backend from all to primary on windows
#7733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
alice-i-cecile
added
the
X-Controversial
|
Could we use From my understanding of #7620 (comment) it's more likely to happen on windows, while the |
james7132
requested changes
Feb 19, 2023
superdump
reviewed
Feb 20, 2023
Co-authored-by: Robert Swain <robert.swain@gmail.com>
LiamGallagher737
changed the title
all to primaryall to primary on windows
Co-authored-by: James Liu <contact@jamessliu.com>
james7132
approved these changes
Feb 20, 2023
alice-i-cecile
approved these changes
Feb 20, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
Comment on lines
48
to
55
| let default_backends = if cfg!(feature = "webgl") { | ||
| Backends::GL | ||
| // TODO: When https://github.com/gfx-rs/wgpu/issues/2540 is fixed, Windows can also use all() | ||
| } else if cfg!(target_os = "windows") { | ||
| Backends::PRIMARY | ||
| } else { | ||
| Backends::all() | ||
| }; |
There was a problem hiding this comment.
Perhaps this logic should be moved to a Default impl on Backends?
|
A new glow patch is out which should fix the issue so hold off on merging this. |
|
This is now released: closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Temporary fix for #7620
Solution
Revert the default wgpu backends back to
PRIMARYfromall().Reverting #7481
I personally believe this is a temporary fix for 0.10, if gfx-rs/wgpu#2540 is fixed before 0.10 I think if should be fine to leave it on
all()but that issue hasn't had much activity.I think we should also keep in mind wither more people are running into the issue of
Unable to find a GPU!than there are people suffering from #7620 to try and please the most users.