Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add example to show how to use apply_system_buffers #7793

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Add example to show how to use apply_system_buffers #7793

wants to merge 3 commits into from

Conversation

wilk10
Copy link
Contributor

@wilk10 wilk10 commented Feb 23, 2023

Objective

This PR adds an example that shows how to use apply_system_buffers and how to order it with respect to the relevant systems. It also shows how not ordering the systems can lead to unexpected behaviours.

Solution

Add the example.

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples labels Feb 23, 2023
Carter0
Carter0 reviewed Feb 25, 2023
View reviewed changes
Copy link
Contributor

@Carter0 Carter0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep trying to pull this down to test it out, but I'm struggling with git haha. Is there a way for me to try this out locally? It's hard to tell how much I like this without running it myself

@alice-i-cecile
Copy link
Member

I keep trying to pull this down to test it out, but I'm struggling with git haha. Is there a way for me to try this out locally? It's hard to tell how much I like this without running it myself

Create a test project with a git dependency on bevy main, copy-paste the example code :)

I also recommend the gh CLI from Github; makes checking out PRs for review a breeze.

@wilk10 wilk10 force-pushed the apply-system-buffers branch from c905843 to f9e6002 Compare February 27, 2023 07:38
@alice-i-cecile alice-i-cecile modified the milestone: 0.10 Feb 27, 2023
@mockersf mockersf added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 27, 2023
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Feb 28, 2023
@wilk10
Add example to show how to use apply_system_buffers (#7793)
998e983 
# Objective

This PR adds an example that shows how to use `apply_system_buffers` and how to order it with respect to the relevant systems. It also shows how not ordering the systems can lead to unexpected behaviours.

## Solution

Add the example.
@bors
Copy link
Contributor

bors bot commented Feb 28, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Add example to show how to use apply_system_buffers [Merged by Bors] - Add example to show how to use apply_system_buffers Feb 28, 2023
@bors bors bot closed this Feb 28, 2023
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@wilk10 @Shfty
Add example to show how to use apply_system_buffers (bevyengine#7793)
3a0f0b3 
# Objective

This PR adds an example that shows how to use `apply_system_buffers` and how to order it with respect to the relevant systems. It also shows how not ordering the systems can lead to unexpected behaviours.

## Solution

Add the example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carter0 Carter0 Carter0 left review comments

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wilk10 @alice-i-cecile @mockersf @Carter0