Add depending bevy features for higher level one #7855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Meta
alice-i-cecile
approved these changes
Mar 2, 2023
alice-i-cecile
added
A-Rendering
james7132
approved these changes
Mar 9, 2023
james7132
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Mar 9, 2023
|
@nicopap you may need to force push to fix CI. |
- Fixes bevyengine#7854 Typically, when using a bevy feature such as `bevy_pbr`, users will need to spawn a camera, sometimes manipulate meshes. Which requires enabling other bevy features. This commit adds those features as dependencies of "higher level" features, so that the end user is not burdened with hunting which feature need which other feature.
auto-merge was automatically disabled
March 13, 2023 20:10
Head branch was pushed to by a user without write access
nicopap
force-pushed
the
add-feature-dependencies
branch
from
d2b032d
to
e01af0f
Compare
|
This doesn't add new dependencies, I guess CI is broken again :/ Also given #8081, I think it's legitimate to try to get this merged. |
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
Shfty
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Typically, when using a bevy feature such as
bevy_pbrin combination withthe
no-default-featuressystem, users will need to spawn a camera,sometimes manipulate meshes. Which requires enabling other bevy features.
The process of finding what features need to be enabled is time consuming
and frustrating, as the error messages do not give a hint as of what needs to
be done.
Solution
This commit adds those features as dependencies of "higher level"
features, so that the end user is not burdened with hunting which
feature need which other feature. And everyone was happy
eversoafter.
Note that since the higher level crates already depend internally
on lower level crates, the only compilation time increase would
be when generating the
bevydoc (because seemingly,rustdocis very slow at resolving re-exports)Changelog
bevy_pbrnow automatically adds lower level features (such asbevy_core_pipelineandbevy_render)