Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize empty schedules when calling .in_schedule if they do not already exist #7911

Merged
merged 8 commits into from
Mar 9, 2023
Merged

Initialize empty schedules when calling .in_schedule if they do not already exist #7911

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0ab7701
add schedule if it is not exist yet
SET001 Mar 5, 2023
9db98b7
cargo fmt
SET001 Mar 6, 2023
b551e56
Merge branch 'bevyengine:main' into main
SET001 Mar 7, 2023
506128b
update solution and add test
SET001 Mar 7, 2023
333afe8
working solution
SET001 Mar 7, 2023
e685681
tests for add_systems and some more
SET001 Mar 7, 2023
7d72cd1
updated doc comments for in_schedule
SET001 Mar 7, 2023
3ec399b
update in docs comments
SET001 Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/bevy_app/src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,9 @@ impl App {
if let Some(schedule) = schedules.get_mut(&*schedule_label) {
schedule.add_system(system);
} else {
panic!("Schedule {schedule_label:?} does not exist.")
self
.add_schedule(schedule_label, Schedule::new())
.add_system(system);
SET001 marked this conversation as resolved.
Show resolved Hide resolved
}
} else if let Some(default_schedule) = schedules.get_mut(&*self.default_schedule_label) {
default_schedule.add_system(system);
Expand Down