Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix viewport change detection #8323

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Fix viewport change detection #8323

merged 2 commits into from
Apr 10, 2023

Conversation

tim-blackbird
Copy link
Contributor

@tim-blackbird tim-blackbird commented Apr 7, 2023 •
edited
Loading

Objective

Fix #8321

Solution

The old_viewport_size that is used to detect whether the viewport has changed was not being updated and thus always None.

@james7132 james7132 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Apr 10, 2023
@james7132 james7132 added this pull request to the merge queue Apr 10, 2023
@james7132 james7132 added this to the 0.11 milestone Apr 10, 2023
Merged via the queue into bevyengine:main with commit 52ee83e Apr 10, 2023
@JoJoJet JoJoJet modified the milestones: 0.11, 0.10.2 Apr 12, 2023
@tim-blackbird tim-blackbird deleted the viewport-change-detection branch October 10, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
0.10.2
Development

Successfully merging this pull request may close these issues.

Resetting viewport of camera with orthographic projection results in stretching
4 participants
@tim-blackbird @james7132 @mockersf @JoJoJet