Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Label traits such as
ScheduleLabel
currently have a major footgun: the trait is implemented forBox<dyn ScheduleLabel>
, but the implementation does not function as one would expect sinceBox<T>
is considered to be a distinct type fromT
. This is because the behavior of theScheduleLabel
trait is specified mainly through blanket implementations, which preventsBox<dyn ScheduleLabel>
from being properly special-cased.Solution
Replace the blanket-implemented behavior with a series of methods defined on
ScheduleLabel
. This allows us to fully special-caseBox<dyn ScheduleLabel>
.Changelog
Fixed a bug where boxed label types (such as
Box<dyn ScheduleLabel>
) behaved incorrectly when compared with concretely-typed labels.Migration Guide
The
ScheduleLabel
trait has been refactored to no longer depend on the traitsstd::any::Any
,bevy_utils::DynEq
, andbevy_utils::DynHash
. Any manual implementations will need to implement new trait methods in their stead.