Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Update depth buffer with parallax mapping result #8486

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

WIP: Update depth buffer with parallax mapping result #8486

wants to merge 5 commits into from

Conversation

nicopap
Copy link
Contributor

@nicopap nicopap commented Apr 25, 2023

Objective

The current parallax mapping implementation doesn't play well with depth-based feature, since it only updates the fragment color in the main pass.

Effects that depend on depth will not work properly. This includes existing and future rendering features, such as:

  • Shadow mapping
  • Screen space ambient occlusion
  • Fog
  • Temporal anti-aliasing
  • Screen space reflection
  • etc.

Solution

We update pbr_prepass to account for depth evaluated by parallax mapping

TODO

Everything is broken, the code is full of debug stuff 😅

@nicopap nicopap added C-Feature A new feature, making something new possible A-Rendering Drawing game state to the screen labels Apr 25, 2023
@nicopap nicopap mentioned this pull request Apr 25, 2023
Open
9 tasks
@JMS55 JMS55 mentioned this pull request Jun 3, 2023
Closed
@BenjaminBrienen BenjaminBrienen added D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Feature A new feature, making something new possible D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged
Projects
Rendering
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicopap @BenjaminBrienen