Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all basic color constants #859

Merged
merged 3 commits into from Nov 15, 2020
Merged

Add all basic color constants #859

merged 3 commits into from Nov 15, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 13, 2020

No description provided.

@karroffel karroffel added A-Core Common functionality for all bevy apps C-Feature A new feature, making something new possible labels Nov 13, 2020
@@ -26,13 +26,44 @@ pub struct Color {
unsafe impl Byteable for Color {}

impl Color {
pub const ALICEBLUE: Color = Color::rgb_linear(0.94, 0.97, 1.0);
pub const ANTIQUEWHITE: Color = Color::rgb_linear(0.98, 0.92, 0.84);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we "rustify" these multi-word constants? Ex: ANTIQUEWHITE -> ANTIQUE_WHITE

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@cart cart merged commit b3541a9 into bevyengine:master Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Core Common functionality for all bevy apps C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants