Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Shaders / Material - GLSL example not working in WebGPU examples page #8680

Closed
wants to merge 1 commit into from

Conversation

marlyx
Copy link
Contributor

@marlyx marlyx commented May 25, 2023

Objective

Fix the glsl material example not working on the WebGPU examples page. Currently it fails with the following error:

panicked at 'not implemented: Enable feature "shader_format_glsl" to use GLSL shaders', crates/bevy_render/src/render_resource/shader.rs:215:21

Solution

Add feature "shader_format_glsl" to builds in the build-wasm-examples tool.

@james7132 james7132 requested a review from mockersf May 25, 2023 15:55
@james7132 james7132 added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash O-Web Specific to web (WASM) builds C-Examples An addition or correction to our examples labels May 25, 2023
@mockersf
Copy link
Member

mockersf commented Jun 1, 2023

I would prefer to fix #8657 before tackling this one. This feature doesn't really make sense to build most webgpus examples and should not be added blindly like that.

@mnmaita
Copy link
Member

mnmaita commented Jun 3, 2024

Closing, as the example page seems to be working correctly now. These changes are stale AFAICS. Feel free to reopen if this resurfaces or if I overlooked something. Thanks!

@mnmaita mnmaita closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples O-Web Specific to web (WASM) builds P-Crash A sudden unexpected crash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants