Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all_tuples + added docs. #8743

Merged
merged 5 commits into from
Jun 2, 2023
Merged

Fix all_tuples + added docs. #8743

merged 5 commits into from
Jun 2, 2023

Conversation

iiYese
Copy link
Contributor

@iiYese iiYese commented Jun 2, 2023

  • Fix out of range indexing when invoking with start greater than 1.
  • Added docs to make the expected behavior clear.

@iiYese iiYese changed the title Fix all_tuple + added docs. Fix all_tuples + added docs. Jun 2, 2023
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change labels Jun 2, 2023
@alice-i-cecile alice-i-cecile requested a review from JoJoJet June 2, 2023 12:24
JoJoJet
JoJoJet reviewed Jun 2, 2023
View reviewed changes
Copy link
Member

@JoJoJet JoJoJet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct, I have a few suggestions for the examples though.

crates/bevy_utils/macros/src/lib.rs Outdated Show resolved Hide resolved
crates/bevy_utils/macros/src/lib.rs Outdated Show resolved Hide resolved
crates/bevy_utils/macros/src/lib.rs Show resolved Hide resolved
crates/bevy_utils/macros/src/lib.rs Outdated Show resolved Hide resolved
@iiYese iiYese requested review from JoJoJet and alice-i-cecile June 2, 2023 15:28
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 2, 2023
Merged via the queue into bevyengine:main with commit 265a25c Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoJoJet JoJoJet JoJoJet approved these changes

@alice-i-cecile alice-i-cecile Awaiting requested review from alice-i-cecile

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior C-Code-Quality A section of code that is hard to understand or change C-Docs An addition or correction to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iiYese @alice-i-cecile @JoJoJet