Skip to content

Conversation

@bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Nov 17, 2020

See the individual commits for more info.

@bjorn3 bjorn3 force-pushed the misc_cleanups branch 10 times, most recently from b1f6d7c to f4200ce Compare November 17, 2020 11:36
@Moxinilian Moxinilian added the C-Code-Quality A section of code that is hard to understand or change label Nov 17, 2020
@cart
Copy link
Member

cart commented Nov 17, 2020

Much appreciated! I think @bitshifter (glam author) had the glam fixes queued up, but its first-come first-served 😄

@cart cart merged commit d6eb647 into bevyengine:master Nov 17, 2020
@bjorn3 bjorn3 deleted the misc_cleanups branch November 17, 2020 22:02
@nic96
Copy link
Contributor

nic96 commented Nov 17, 2020

I'm getting errors with this:

error[E0615]: attempted to take value of method `x` on type `glam::Vec2`
  --> bevy/crates/bevy_math/src/geometry.rs:68:37
   |
68 |             width: self.width + rhs.x,
   |                                     ^ method, not a field
   |
help: use parentheses to call the method
   |
68 |             width: self.width + rhs.x(),
   |                                      ^^

error[E0615]: attempted to take value of method `y` on type `glam::Vec2`
  --> bevy/crates/bevy_math/src/geometry.rs:69:39
   |
69 |             height: self.height + rhs.y,
   |                                       ^ method, not a field
   |
help: use parentheses to call the method
   |
69 |             height: self.height + rhs.y(),
   |                                        ^^

error[E0615]: attempted to take value of method `x` on type `glam::Vec2`
  --> bevy/crates/bevy_math/src/geometry.rs:79:27
   |
79 |         self.width += rhs.x;
   |                           ^ method, not a field
   |
help: use parentheses to call the method
   |
79 |         self.width += rhs.x();
   |                            ^^

error[E0615]: attempted to take value of method `y` on type `glam::Vec2`
  --> bevy/crates/bevy_math/src/geometry.rs:80:28
   |
80 |         self.height += rhs.y;
   |                            ^ method, not a field
   |
help: use parentheses to call the method
   |
80 |         self.height += rhs.y();
   |                             ^^

error: aborting due to 4 previous errors

@nic96
Copy link
Contributor

nic96 commented Nov 17, 2020

Ok, I deleted my Cargo.lock and that fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-Code-Quality A section of code that is hard to understand or change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants