Add a method to run read-only systems using &World
#8849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
added
C-Feature
There was a problem hiding this comment.
Isn't this missing a blanket impl for ReadOnlySystem for functions that take &World?
Ideally this would also be implemented for all systems where all of the parameters are read-only as well, but until we can actually make queries via &World this isn't going to be super useful either way.
|
This trait is implemented for any function system whose parameters all implement |
|
Oh I see! The trait already existed. Fantastic, thank you :) |
alice-i-cecile
approved these changes
Jun 15, 2023
james7132
approved these changes
Jun 15, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Resolves #7558.
Systems that are known to never modify the world implement the trait
ReadOnlySystem. This is a perfect place to add a safe API for running a system with a shared reference to a World.Changelog
ReadOnlySystem::run_readonly, which allows a system to be run using&World.