Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix #1018 (Textures on the
Plane
shape appear flipped).This bug have been around for a very long time apparently, I tested it was still there (see test code bellow) and sure enough, this image:
... is flipped vertically when used as a texture on a plane (in main, 0.10.1 and 0.9):
I'm pretty confused because this bug is so easy to fix, it has been around for so long, it is easy to encounter, and PRs touching this code still didn't fix it: #7546 To the point where I'm wondering if it's actually intended. If it is, please explain why and this PR can be changed to "mention that in the doc".
Solution
Fix the UV mapping on the Plane shape
Here is how it looks after the PR
Test code
Changelog
Fix textures on
Plane
shapes being flipped vertically.Migration Guide
Flip the textures you use on
Plane
shapes.