Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change despawn_descendants to return &mut Self #8928

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Change despawn_descendants to return &mut Self #8928

merged 4 commits into from
Jun 23, 2023

Conversation

AnbyKatz
Copy link
Contributor

Objective

Solution

  • Change function signature despawn_descendants under trait DespawnRecursiveExt.
  • Add single extra test spawn_children_after_despawn_descendants (May be unnecessary)

@github-actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@AnbyKatz AnbyKatz changed the title Despawn descendants return self Change despawn_descendants to return &mut Self Jun 22, 2023
@mockersf mockersf added C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Hierarchy Parent-child entity hierarchies labels Jun 22, 2023
@alice-i-cecile alice-i-cecile enabled auto-merge June 23, 2023 01:52
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 23, 2023
Merged via the queue into bevyengine:main with commit 29f7293 Jun 23, 2023
@AnbyKatz AnbyKatz deleted the despawn-descendants-return-self branch June 23, 2023 03:06
@Shatur Shatur mentioned this pull request Jun 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Hierarchy Parent-child entity hierarchies C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnbyKatz @alice-i-cecile @mockersf