Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous shader_format_glsl feature #8969

Closed
wants to merge 1 commit into from
Closed

Remove superfluous shader_format_glsl feature #8969

wants to merge 1 commit into from

Conversation

rparrett
Copy link
Contributor

Objective

naga_oil now includes glsl support unconditionally, so this feature isn't doing anything.

Fixes #8505 (see recent discussion there and in #8657)

Solution

Remove the feature

Changelog

  • Removed the shader_material_glsl feature. glsl support is now included by default.

Migration Guide

The shader_material_glsl feature was removed. glsl support is now included by default. If you were previously using this feature, you can remove it from your Cargo.toml.

@rparrett rparrett mentioned this pull request Jun 27, 2023
Closed
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Jun 27, 2023
@alice-i-cecile alice-i-cecile added this to the 0.11 milestone Jun 27, 2023
mockersf
mockersf requested changes Jun 27, 2023
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to make it optional in naga_oil

@rparrett
Copy link
Contributor Author

Cool, me too. I was under the false impression that wasn't going to happen in time for 0.11.

@rparrett rparrett closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf requested changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

example shader_material_glsl panics due to missing feature
3 participants
@rparrett @alice-i-cecile @mockersf