Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main
/Render
schedules be run at different real timing. #8976base: main
Are you sure you want to change the base?
Main
/Render
schedules be run at different real timing. #8976Changes from all commits
5685ec3
a919628
e10458b
f210bed
91bb64d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is worse: we're leaking internal details and making a very common operation more verbose.
Can we keep
App::update
around and just call this on the main schedule label?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not do any test code refactoring, so it is verbose. 😅
Generally,
&mut World
is passed in the exclusive system, so it is basically never used in that form. Probably in the form of runner functions and test code only.And this PR will no longer be used in the engine code. So I think the maintenance will be forgotten and
App::update
will stop working somewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following up on @alice-i-cecile 's question, can we keep
App::update()
?It is used in tests and examples, and replacing it with the four-line stanza makes it more difficult to write tests that need to run schedules. Making testing more difficult should be avoided. I say this after adding easily a dozen
app.update()
calls in the stepping PR for an example demonstrating stepping.The same argument applies if we replace the dozens of the existing
App::update()
calls with four other lines. The difference is that we'll only need to fixApp::update()
when it breaks.I think we do need for some function to exist on
mut App
that is the equivalent of "run everything".