Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Eq, PartialEq for Tick #9020

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Derive Eq, PartialEq for Tick #9020

merged 1 commit into from
Jul 4, 2023

Conversation

chrisjuchem
Copy link
Contributor

Objective

  • Remove need to call .get() on two ticks to compare them for equality.

Solution

  • Derive Eq and PartialEq.

Changelog

Tick now implements Eq and PartialEq

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 4, 2023
@mockersf mockersf added this pull request to the merge queue Jul 4, 2023
Merged via the queue into bevyengine:main with commit ca3068a Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B-Reif B-Reif B-Reif approved these changes

@mockersf mockersf mockersf approved these changes

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisjuchem @alice-i-cecile @mockersf @B-Reif