Fix duplicated chilren in Scene spawn #904
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #889,
TLDR;
The Problem
Childrencomponent while spawning a scenetransform_propagate_systemtook 13ms in release with a small skeleton tree ~20 bonesSceneis usingWorldBuilder.with(Parent(...))(still wrong for other reasons)The Fix
FromResourcesandMapEntitiesforPrevousParentChildrenusing adebug_assertChildren.0andPreviousParent.0are nowpub(crate), their contents are a reflect ofParentConclusion
This is the best short term fix, it will make so that the only true correct way of creating
Scenewill beWorldBuilder.with_childrenwhich has no caviats