Stop using unwrap in the pipelined rendering thread #9052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
C-Bug
IceSentry
approved these changes
Jul 5, 2023
hymm
approved these changes
Jul 7, 2023
james7132
added
the
S-Ready-For-Final-Review
Aceeri
approved these changes
Jul 16, 2023
mockersf
approved these changes
Jul 22, 2023
cart
pushed a commit
that referenced
this pull request
Aug 10, 2023
# Objective Fix #8936. ## Solution Stop using `unwrap` in the core pipelined rendering logic flow. Separately also scoped the `sub app` span to just running the render app instead of including the blocking send. Current unknowns: should we use `std::panic::catch_unwind` around running the render app? Other engine threads use it defensively, but we're letting it bubble up here, and a user-created panic could cause a deadlock if it kills the thread. --- ## Changelog Fixed: Pipelined rendering should no longer have spurious panics upon app exit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fix #8936.
Solution
Stop using
unwrapin the core pipelined rendering logic flow.Separately also scoped the
sub appspan to just running the render app instead of including the blocking send.Current unknowns: should we use
std::panic::catch_unwindaround running the render app? Other engine threads use it defensively, but we're letting it bubble up here, and a user-created panic could cause a deadlock if it kills the thread.Changelog
Fixed: Pipelined rendering should no longer have spurious panics upon app exit.