Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Changed from parent update system #907

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

svents
Copy link
Contributor

@svents svents commented Nov 21, 2020

This is a possible fix for issue #891.

@cart
Copy link
Member

cart commented Nov 22, 2020

Can you add a comment to the query to indicate that we would like it to be "Changed", but doing so produces the bug from #891?

System has to check for actual change of the value anyway. This way,
children inserted after postupdate get synced in the next frame and are
not lost.
@svents svents force-pushed the lost_children_after_postupdate branch from 0453c59 to c13cce7 Compare November 23, 2020 17:18
@svents
Copy link
Contributor Author

svents commented Nov 23, 2020

Done.

@cart cart merged commit de5ff0a into bevyengine:master Nov 26, 2020
@fopsdev fopsdev mentioned this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants