only take up to the max number of joints #9351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicopap
approved these changes
Aug 5, 2023
|
added a warning 👍 |
JMS55
reviewed
Aug 15, 2023
| @@ -497,6 +498,16 @@ async fn load_gltf<'a, 'b>( | |||
| .map(|node| node_index_to_entity_map[&node.index()]) | |||
| .collect(); | |||
|
|
|||
| if joint_entities.len() > MAX_JOINTS && warned_about_max_joints.insert(skin_index) { | |||
There was a problem hiding this comment.
Does this properly short circuit, and not insert into the hashmap if the len <= MAX_JOINTS?
There was a problem hiding this comment.
yes that's how && works in rust, see https://doc.rust-lang.org/reference/expressions/operator-expr.html#lazy-boolean-operators
JMS55
approved these changes
Aug 25, 2023
nicopap
added
C-Bug
robtfm
pushed a commit
to robtfm/bevy
that referenced
this pull request
Sep 1, 2023
# Objective - Meshes with a higher number of joints than `MAX_JOINTS` are crashing - Fixes partly bevyengine#9021 (doesn't crash anymore, but the mesh is not correctly displayed) ## Solution - Only take up to `MAX_JOINTS` joints when extending the buffer
vprime
pushed a commit
to vprime/bevy
that referenced
this pull request
Sep 22, 2023
# Objective - Meshes with a higher number of joints than `MAX_JOINTS` are crashing - Fixes partly bevyengine#9021 (doesn't crash anymore, but the mesh is not correctly displayed) ## Solution - Only take up to `MAX_JOINTS` joints when extending the buffer (cherry picked from commit b28f633)
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective - Meshes with a higher number of joints than `MAX_JOINTS` are crashing - Fixes partly bevyengine#9021 (doesn't crash anymore, but the mesh is not correctly displayed) ## Solution - Only take up to `MAX_JOINTS` joints when extending the buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
MAX_JOINTSare crashingSolution
MAX_JOINTSjoints when extending the buffer