Adding Copy, Clone, Debug to derived traits of ExecutorKind
#9385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
urben1680
changed the title
Clone to derived traits of ExcutorKind
nicopap
approved these changes
Aug 8, 2023
|
It is probably fine to derive |
urben1680
changed the title
Clone to derived traits of ExcutorKindClone to derived traits of ExecutorKind
urben1680
changed the title
Clone to derived traits of ExecutorKindCopy, Clone to derived traits of ExecutorKind
killercup
approved these changes
Aug 8, 2023
nicopap
added
A-ECS
mockersf
approved these changes
Aug 8, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
djeedai
approved these changes
Aug 10, 2023
|
The merge failed, so there is still time for |
urben1680
changed the title
Copy, Clone to derived traits of ExecutorKindCopy, Clone, Debug to derived traits of ExecutorKind
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While being nobody other's issue as far I can tell, I want to create a trait I plan to implement on
Appwhere more than one schedule is modified.My workaround so far was working with a closure that returns an
ExecutorKindfrom a match of the method variable.It makes it easier for me to being able to clone
ExecutorKindand I don't see this being controversial for others working with Bevy.I did nothing more than adding
Cloneto the derived traits, no migration guide needed.(If this worked out then the GitHub editor is not too shabby.)