Remove Resource and add Debug to TaskPoolOptions #9485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
PR #6360 changed
TaskPoolOptions
so it is no longer used as a Resource, but didn't remove theResource
derive.Solution
Remove the Resource derive from
TaskPoolOptions
, as it is no longer needed. Also add a Debug derive, because it didn't have it before.Changelog
TaskPoolOptions
no longer derives Resource, andTaskPoolOptions
&TaskPoolThreadAssignmentPolicy
now derive Debug.Migration Guide
If for some reason anyone is still using
TaskPoolOptions
as a Resource, they would now have to use a wrapper type: