Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Resource and add Debug to TaskPoolOptions #9485

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

BigWingBeat
Copy link
Contributor

Objective

PR #6360 changed TaskPoolOptions so it is no longer used as a Resource, but didn't remove the Resource derive.

Solution

Remove the Resource derive from TaskPoolOptions, as it is no longer needed. Also add a Debug derive, because it didn't have it before.


Changelog

  • TaskPoolOptions no longer derives Resource, and TaskPoolOptions & TaskPoolThreadAssignmentPolicy now derive Debug.

Migration Guide

If for some reason anyone is still using TaskPoolOptions as a Resource, they would now have to use a wrapper type:

#[derive(Resource)]
pub struct MyTaskPoolOptions(pub TaskPoolOptions);

@github-actions
Copy link
Contributor

Example alien_cake_addict failed to run, please try running it locally and check the result.

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Tasks Tools for parallel and async work M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide labels Aug 19, 2023
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Aug 19, 2023
@mockersf mockersf added this pull request to the merge queue Aug 20, 2023
Merged via the queue into bevyengine:main with commit 02ac5c4 Aug 20, 2023
@BigWingBeat BigWingBeat deleted the taskpooloptions branch August 30, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tasks Tools for parallel and async work C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants