-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix point light radius #9493
Fix point light radius #9493
Conversation
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
Example |
I feel like this should probably have a migration guide section since it will change the way scenes look. Unfortunately since KHR_lights_punctual doesn't have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, but needs a migration guide letting people know about the change.
Not sure what the migration guide would be, as there is now no way to achieve the previous behaviour, and the previous behaviour was also nonsensical as it would mean the point light has instant falloff from the given intensity to 0 at the radius, ie. the light source only radiates inside itself while emitting no light. Edit: from the PR template: "Fixing behavior that was definitely a bug, rather than a questionable design choice is not a breaking change." |
Objective
Fixes #9488
Solution
Set point light radius to always be 0.0. Reading this value from glTF would require using application specific extras property.
Changelog
Fixed