Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ktx2: Fix Rgb8 -> Rgba8Unorm conversion #9555

Merged
merged 1 commit into from
Aug 24, 2023
Merged

ktx2: Fix Rgb8 -> Rgba8Unorm conversion #9555

merged 1 commit into from
Aug 24, 2023

Conversation

superdump
Copy link
Contributor

Objective

Solution

  • Only n_pixels bytes of data was being copied instead of 1 byte per component, i.e. n_pixels * 4

Changelog

  • Fixed: loading of Rgb8 ktx2 files.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Aug 24, 2023
@superdump superdump added this pull request to the merge queue Aug 24, 2023
Merged via the queue into bevyengine:main with commit b88ff15 Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to load KTX2 cubemap
2 participants
@superdump @alice-i-cecile