Remove Val's try_* arithmetic methods
#9609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
alice-i-cecile
added
M-Needs-Migration-Guide
alice-i-cecile
approved these changes
Aug 28, 2023
nicoburns
approved these changes
Aug 28, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective Remove `Val`'s `try_*` arithmetic methods. fixes bevyengine#9571 ## Changelog Removed these methods from `bevy_ui::ui_node::Val`: - `try_add` - `try_sub` - `try_add_assign_with_size` - `try_sub_assign_with_size` - `try_add_assign` - `try_sub_assign` - `try_add_assign_with_size` - `try_sub_assign_with_size` ## Migration Guide `Val`'s `try_*` arithmetic methods have been removed. To perform arithmetic on `Val`s deconstruct them using pattern matching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Remove
Val'stry_*arithmetic methods.fixes #9571
Changelog
Removed these methods from
bevy_ui::ui_node::Val:try_addtry_subtry_add_assign_with_sizetry_sub_assign_with_sizetry_add_assigntry_sub_assigntry_add_assign_with_sizetry_sub_assign_with_sizeMigration Guide
Val'stry_*arithmetic methods have been removed. To perform arithmetic onVals deconstruct them using pattern matching.